-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Pandas deprecations #161
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 98.64% 98.74% +0.09%
==========================================
Files 29 29
Lines 3035 3031 -4
==========================================
- Hits 2994 2993 -1
+ Misses 41 38 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How interesting! Thanks for looking into and resolving this @adamovanja. Docker image has been updated and runs successfully.
Just wondering, how come the 2023.9 tag of q2-fondue is filed under the 2023.7 QIIME 2 release according to the package directory?
Co-authored-by: Lina Kim <lina-kim@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @adamovanja! Also runs successfully with this code + pandas v2.0.3 (in a container with qiime2, q2-types, and q2cli v2023.2).
This PR ensures forward compatibility with pandas v2.0 and maintains usablility with pandas version <2.0. It fixes #160.
Note on testing:
The below test should fail when installing q2-fondue from channel "https://packages.qiime2.org/qiime2/2023.2/tested/" as currently described in the main channel
README.md
file (and done in the Docker image). The test works without errors when using the updated code.Using q2-fondue from channel "https://packages.qiime2.org/qiime2/2023.7/tested/" the code works independently (code from main channel or this PR).
README.md
file.Test A:
Note before merging