FIX: remove original sequences after gzipping #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 29 29
Lines 2974 2980 +6
=======================================
+ Hits 2933 2939 +6
Misses 41 41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adamovanja
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Thanks for fixing this @misialq ⭐. The code changes look good to me.
Also, the used TMPDIR size did decrease significantly. Here the TMPDIR size occupied (in GB) when testing get-sequences for accession ID PRJEB11697:
| # fetched run IDs | MAIN | FIX |
|---|---|---|
| 42 | 3.15 | 0.52 |
| 76 | 5.27 | 0.86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151.
To test, fetch a significantly sized dataset and compare the size of the TMPDIR towards the end of the sequence fetch (but before the action finishes): the size should be significantly smaller with the changes in this PR, in contrast to the main version.