Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Rails 7 #225

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

cseelus
Copy link
Contributor

@cseelus cseelus commented Dec 16, 2021

Simple update to the gemspec file, to make font-awesome-rails compatible with Rails 7, released December 15, 2021.

Fixes #224

@rmm5t
Copy link
Collaborator

rmm5t commented Dec 20, 2021

Thank you. I'm going to update the CI workflows to make sure we have test coverage, but I'll try to get this merged and released sometime today.

@rmm5t rmm5t merged commit b3d2685 into bokmann:master Dec 20, 2021
@epugh
Copy link

epugh commented Dec 20, 2021

I saw the new release, but not tweaks to the CHANGELOG document, would be nice to see that doc updated as well!

@rmm5t
Copy link
Collaborator

rmm5t commented Dec 20, 2021

@epugh I updated the CHANGELOG for ease/completeness, but GitHub releases have replaced the CHANGELOG:

See GitHub Releases for all future releases

@viviana-aline
Copy link

When I import the font-awesome CSS in Rails 7 in application.css with

/*
 *= require font-awesome
 */

as the documentation says, it still doesn't load the CSS (icons are not loading), so it doesn't seem entirely compatible with Rails 7...unless I'm doing something wrong. I tried to import the CSS manually with the old CDN link, and the icons are loading fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Rails 7.0
4 participants