Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove initialized and init(...) that supported using a non-0 SENTINEL #4

Closed
bokkypoobah opened this issue Feb 24, 2019 · 1 comment
Closed

Remove initialized and init(...) that supported using a non-0 SENTINEL #4

bokkypoobah opened this issue Feb 24, 2019 · 1 comment

Comments

@bokkypoobah
Copy link
Owner

The code currently allows SENTINEL to be set to a non-0 value, and the init(...) constructor initialises the required data structures to handle the non-0 SENTINEL.

The other place that requires special handling for a non-0 SENTINEL is getNode(...). This support was removed in #3, so may as well remove the support for a non-0 SENTINEL
bokkypoobah added a commit that referenced this issue Feb 24, 2019
@bokkypoobah
Remove initialized and init(...) #4
8133a67
@bokkypoobah
Copy link
Owner Author

Gas Before:

minGasUsedInsert=68318
averageGasUsedInsert=112496.21875
maxGasUsedInsert=167842
minGasUsedRemove=30542
averageGasUsedRemove=80300.5
maxGasUsedRemove=190402

Gas After:

minGasUsedInsert=68318
averageGasUsedInsert=112496.21875
maxGasUsedInsert=167842
minGasUsedRemove=30542
averageGasUsedRemove=80300.5
maxGasUsedRemove=190402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bokkypoobah