Skip to content

Commit

Permalink
Merge #41
Browse files Browse the repository at this point in the history
41: Use more github actions as checks  r=antifuchs a=antifuchs

This updates the CI integration for some cool cargo checks via the [actions-rs](https://github.com/actions-rs) repositories:

* [cargo clippy](https://github.com/actions-rs/clippy-check) for nice annotations on the commit. (No annotations on the PR, as there are token permission issues: actions-rs/clippy-check#2)
* [cargo audit](https://github.com/actions-rs/audit-check) for security checks.

Thanks to the [this blog post](https://svartalf.info/posts/2020-04-10-github-action-for-binary-crates-installation/) for pointing me to those.

Co-authored-by: Andreas Fuchs <asf@boinkor.net>
  • Loading branch information
bors[bot] and antifuchs authored Jun 25, 2020
2 parents 8899976 + 5b9b96b commit 010a56b
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 27 deletions.
14 changes: 0 additions & 14 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -167,20 +167,6 @@ workflows:
"/^v\\d+\\.\\d+\\.\\d+.*$/"
]
}
}
- clippy:
version: stable
filters: {
"branches": {
"ignore": [
"/.*\\.tmp/"
]
},
"tags": {
"only": [
"/^v\\d+\\.\\d+\\.\\d+.*$/"
]
}
}
- bench:
version: nightly
Expand Down
13 changes: 0 additions & 13 deletions .github/workflows/cargo_deny.yml

This file was deleted.

34 changes: 34 additions & 0 deletions .github/workflows/ci_checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: "Additional CI"
# This workflow is triggered on pushes to the repository.
on: [push]

jobs:
cargo_deny:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: "cargo deny"
uses: EmbarkStudios/cargo-deny-action@v1.0.1 # Effectively cargo-deny 0.6.7
with:
command: "check all"
cargo_clippy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: "cargo clippy"
uses: actions-rs/clippy-check@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
args: -- -D warnings
cargo_audit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions-rs/install@v0.1
with:
crate: cargo-audit
use-tool-cache: true
- name: "cargo audit"
uses: actions-rs/audit-check@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
4 changes: 4 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ autobenches = false
run = true
version = "nightly"

[package.metadata.template_ci.clippy]
run = false
version = "nightly"

[package.metadata.template_ci.additional_matrix_entries]

[package.metadata.template_ci.additional_matrix_entries.no_std_nightly]
Expand Down
2 changes: 2 additions & 0 deletions bors.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
status = [
"continuous_integration",
"cargo_deny",
"cargo_audit",
"cargo_clippy",
]
timeout_sec = 600
delete_merged_branches = true

0 comments on commit 010a56b

Please sign in to comment.