-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure repository to contain the rc crate as well #39
Conversation
I initially tried symlinks but that runs into rust-lang/cargo#2748 :( |
382ce02
to
4659203
Compare
be152db
to
bfc9742
Compare
The way this is structured now is a bit odd but it has reasons. Inside the For publishing the The tests in travis run against the built versions. This is done because This now means that tests run agains the actual release versions and that includes the doctests. If one wants to use a git dependency (like I wanted) then this also works. |
a4bfe31
to
84ca9ed
Compare
84ca9ed
to
2498516
Compare
Thanks, I think I could probably live with this - let me just try it out for a bit before merging and see if I run into any rough edges. |
One thing I'm not happy about is that if I change dependencies in Cargo.toml, I now also have to make sure I change them in rc/Cargo.toml, but without some sort of |
@bodil I could add a |
@bodil I pushed up a version that uses m4 to generate out toml files. Not the most modern thing but pretty straightforward. This also adds a Makefile. |
uuuugh, I'm not keen on adding those dependencies even outside of the build phase. I'll just merge this - seems to work well - but I think I'm likely to rewrite the makefile stuff in Rust... |
Thanks. 👍 |
@bodil fwiw i picked m4 and perl because they are everywhere :) |
I just tagged a new release, |
This changes the way the two crates are built so that it works for both released versions as well as git dependencies to the repository directly for both
im
andim-rc
. Additionally it tests against the release versions of the crates, fixes the doctests referring to the wrong crate for the rc version and parallelizes the travis tests.