Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against php 8.4 #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test against php 8.4 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: ['7.4', '8.0', '8.1', '8.2', '8.3']
php-version: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
dependency-versions: ['highest']
steps:
- name: Install PHP
Expand All @@ -34,4 +34,4 @@ jobs:
dependency-versions: ${{ matrix.dependency-versions }}

- name: Run PHPUnit tests
run: ./vendor/bin/simple-phpunit
run: ./vendor/bin/phpunit
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be reverted. We still need to use simple-phpunit, but if we want to use a newer PHPUnit version - we can specify the exact version with SYMFONY_PHPUNIT_VERSION in phpunit.xml.dist .

3 changes: 2 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
},
"require-dev": {
"dg/bypass-finals": "^1.3",
"symfony/phpunit-bridge": "^5.4|^6.0"
"symfony/phpunit-bridge": "^5.4|^6.0|^7.0",
"phpunit/phpunit": "^9.0|^10.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And so this can be reverted - that's a feature of PHPUnit bridge, it allows you to get rid of PHPUnit dependency directly

},
"config": {
"sort-packages": true
Expand Down
Loading