-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node id detection #54
Conversation
…s related to multiple functions in examples.
|
…ed if using dot notation in new form validation function, and add tests.
…ke "get" method to settings. Rename "text" to "caption" so text of widget itself can be set (since Checkbutton has an integrated text field).
If you could, please make sure the docstring in 2e2e77a is correct, especially |
3ee0001
to
7abb06e
Compare
733d50c
to
eba45cd
Compare
…ove related docstring.
Also, is 4b94c25 correct, or are partial (right a.k.a. more local side) IDs allowed in dot notation?
|
Looks good to me. The mask was written as 0x10_000_000 because the CAN fields are 12 bits each, but changing it to 0x10_00_00_00 definitely makes it easier to read.
I think this is fine. Thanks for making the change. |
This may require discussion, unless you are ok with implementing conventions (as in module features that are a superset of standards).