-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Ligature support #554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99eb924
to
8cd3c42
Compare
8cd3c42
to
445d9d3
Compare
…I is complicating kerning/ligature support
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #554 +/- ##
============================================
+ Coverage 74.29% 74.51% +0.21%
- Complexity 6839 6871 +32
============================================
Files 177 178 +1
Lines 30269 30270 +1
Branches 3915 3920 +5
============================================
+ Hits 22489 22556 +67
+ Misses 5940 5889 -51
+ Partials 1840 1825 -15 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To render ligatures, but also support our "system selection" property where selected text is a different color, we need to update the token painting for partially-selected tokens. We need to render the token twice - once for the unselected piece(s) and once for the selected piece - to ensure ligatures are properly rendered in "both" pieces. Otherwise, if a ligature is partially selected, we'll render the individual chars instead.
Test ligatures to copy-paste:
// ligatures: ## <> => ++ ~~ <= >= <=> ->>
Things to consider:
RSyntaxTextArea.setFont()
should update all fonts in theSyntaxScheme
with ligature-related attributesSyntaxScheme
s should propagage ligature attributes to derived fontsTheme
s should propagate ligataure attributes to derived fontssetFont()
example