Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.1 and PHP 8.2 #2

Closed
bobbingwide opened this issue Oct 11, 2023 · 2 comments
Closed

Support PHP 8.1 and PHP 8.2 #2

bobbingwide opened this issue Oct 11, 2023 · 2 comments
Assignees
@bobbingwide
Labels
enhancement

Comments

@bobbingwide
Copy link
Owner

Update code to run without problems in PHP 8.1 and 8.2

See bobbingwide/bobbingwide#103
@bobbingwide bobbingwide self-assigned this Oct 11, 2023
@bobbingwide
Copy link
Owner Author

bobbingwide commented Oct 12, 2023 •
edited
Loading

In oik_shortcodes_a2z_first_letter() there are two changes to make.

  1. Specifically support null - converting to an empty string
  2. Call remove_accents() before ucfirst() because ucfirst() has been changed for PHP 8.2

Case conversion no longer depends on the locale set with setlocale(). Only ASCII characters will be converted.

See https://www.php.net/manual/en/function.ucfirst.php

bobbingwide added a commit that referenced this issue Oct 12, 2023
@bobbingwide
Support PHP 8.2 #2
23b5cad
@bobbingwide
Copy link
Owner Author

Delivered in v0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbingwide bobbingwide

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobbingwide