opt: remove the repeated validation of 'AlreadyKnwon' transactions, t… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o avoid competitions of lookup mutex
bnoieh
pushed a commit
that referenced
this pull request
Dec 16, 2024
* opt truncatePending and truncateQueue * downgrade the level of log in eth_sendRawTransaction * disable pending cache of legacypool when --mine enabled * split metrics of txpool by cases of 'reorg' and 'reset' * add logs to trace the reset event of txpool * add logs to trace the reset event of txpool --------- Co-authored-by: andyzhang2023 <andyzhang2023@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 'AlreadyKnown' will be do in addTxsLocked() method, and there is no need to do it outside the addTxsLocked() again.