core/trie: persist TrieJournal to journal file instead of kv database #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
pushed a commit
to owen-reorg/op-geth
that referenced
this pull request
Apr 25, 2024
core/types: Include overhead in the L1GasUsed for receipts.
…nal (#2406) * core: check journalType before load journal * fix: when delete trieJournal delete from kv & file
fynnss
previously approved these changes
Jun 11, 2024
chris-Li-Node-Real
approved these changes
Jun 11, 2024
owen-reorg
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR provides another way to persist TrieJournal by write it into a log file instead of a kv database.
Use
--journalFileflag to enable/disable the journal file feature.Rationale
Persisting TrieJournal to KV database will cause problems below
Changes:
Data Format
Journal Version
Disk Root
Disk Layer
Layer ChecksumDiff Layer
Layer ChecksumJournal Path: geth/chaindata/ancient/state.journal
Checksum: SHA256
Performance test
Scenario: Using TestJournal, each layer has 4K and 8K account operations.
Conclusion: The use of Journal WAL and storing trieJournalKey directly into kvdb results in nearly identical WAL write times during shutdown and WAL read/parsing times during startup.