-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt: do verify and commit concurrently #92
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad7b7e5
to
db8f75a
Compare
3d381c7
to
636adf9
Compare
will-2012
previously approved these changes
May 6, 2024
sysvm
previously approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
will-2012
previously approved these changes
May 13, 2024
sysvm
previously approved these changes
May 15, 2024
welkin22
reviewed
May 16, 2024
welkin22
reviewed
May 16, 2024
welkin22
reviewed
May 16, 2024
fix: update by comment tips
welkin22
reviewed
May 17, 2024
bnoieh
reviewed
May 22, 2024
welkin22
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
owen-reorg
approved these changes
Jun 7, 2024
bnoieh
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a concurrency and asynchronous optimization of the verify and commit phases. The goal is to optimize the speed tracking performance and will also bring certain performance improvements for the sequencer node.
Rationale
We have performed performance tests on sequencer and fullnode.
sequencer
fullnode
detail
PBSS + NodeBuffer + Paralle(Verify and Commit): 172.22.43.113
PBSS(NodeBufferList): 172.22.42.179
Starting from a block height of ~1209w (the slight difference in the initial phase is due to network factors), it ran for 13.5 hours. 172.22.43.113 imported ~328w blocks, and 172.22.23.179 imported ~288w blocks.
Example
no
Changes
Notable changes:
no