Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: do verify and commit concurrently #92

Merged
merged 22 commits into from
Jun 7, 2024
Merged

opt: do verify and commit concurrently #92

merged 22 commits into from
Jun 7, 2024

Conversation

joeylichang
Copy link
Collaborator

@joeylichang joeylichang commented Apr 24, 2024

Description

This PR is a concurrency and asynchronous optimization of the verify and commit phases. The goal is to optimize the speed tracking performance and will also bring certain performance improvements for the sequencer node.

Rationale

We have performed performance tests on sequencer and fullnode.

sequencer

Items PBSS + NodeBuffer + Paralle(Verify and Commit) PBSS(NodeBufferList) V0.3.0(HBSS)
TPS(txs/block) 4673(37.8%) 4355(28.5%) 3390
import time 47.6ms 66.8ms 101ms
validate time 20.9ms 22.2ms 17ms
commit time 29.1ms 47.4ms 85.5ms

fullnode

Items PBSS + NodeBuffer + Paralle(Verify and Commit) PBSS(NodeBufferList) Rate
import time 23.3ms 29.9ms 22.1%
execute time 13.1ms 13.6ms 3.7%
validate time 4.24ms 6.29ms 32.6%
commit time 5.89ms 9.76ms 39.7%
detail
截屏2024-04-24 09 26 10

PBSS + NodeBuffer + Paralle(Verify and Commit): 172.22.43.113
PBSS(NodeBufferList): 172.22.42.179

Starting from a block height of ~1209w (the slight difference in the initial phase is due to network factors), it ran for 13.5 hours. 172.22.43.113 imported ~328w blocks, and 172.22.23.179 imported ~288w blocks.

Example

no

Changes

Notable changes:
no

@github-actions github-actions bot requested review from owen-reorg and welkin22 April 24, 2024 01:43
will-2012
will-2012 previously approved these changes May 6, 2024
@joeylichang joeylichang added the R4R Ready for review label May 6, 2024
sysvm
sysvm previously approved these changes May 7, 2024
Copy link
Contributor

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@will-2012 will-2012 dismissed stale reviews from sysvm and themself via a6a9f3c May 8, 2024 08:30
will-2012
will-2012 previously approved these changes May 13, 2024
sysvm
sysvm previously approved these changes May 15, 2024
will@2012 and others added 2 commits May 17, 2024 15:50
@will-2012 will-2012 dismissed stale reviews from sysvm and themself via ee974fd May 17, 2024 08:15
@owen-reorg owen-reorg requested a review from bnoieh May 21, 2024 09:43
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit feb5bfe into develop Jun 7, 2024
1 check passed
@sysvm sysvm deleted the opt_parallel branch July 29, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R4R Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants