config: remove no-headers as it may leads to a dead peer not removing

bnb-chain · Jan 30, 2024 · d0193f8 · d0193f8
1 parent 5a43edc
commit d0193f8
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/eth/protocols/eth/handler.go b/eth/protocols/eth/handler.go
@@ -157,12 +157,16 @@ func Handle(backend Backend, peer *Peer) error {
 	for {
 		err := handleMessage(backend, peer)
 		switch {
+		// TODO: currently no headers not ignored as it may leads to a dead peer not removing as expected
+		/*
+			case errors.Is(err, etherror.ErrNoHeadersDelivered):
+				// ignore no headers delivered
+				peer.Log().Warn("Message handling failed with no headers")
+		*/
 		case errors.Is(err, etherror.ErrInvalidHeaderBatchAnchor):
 			// ignore invalid header anchor
 			peer.Log().Warn("Message handling failed with invalid batch request anchor")
-		case errors.Is(err, etherror.ErrNoHeadersDelivered):
-			// ignore no headers delivered
-			peer.Log().Warn("Message handling failed with no headers")
+
 		case err != nil:
 			peer.Log().Debug("Message handling failed in `eth`", "err", err)
 			return err