[R4R] sidechain staking reward distribution #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
commented
Jan 6, 2022
unclezoro
reviewed
Jan 7, 2022
|
LGTM |
yutianwu
reviewed
Jan 7, 2022
yutianwu
reviewed
Jan 7, 2022
yutianwu
reviewed
Jan 7, 2022
unclezoro
reviewed
Jan 27, 2022
app/app.go
Outdated
| // init new param RewardDistributionBatchSize | ||
| newCtx := ctx.WithSideChainKeyPrefix(storePrefix) | ||
| params := app.stakeKeeper.GetParams(newCtx) | ||
| params.RewardDistributionBatchSize = 100 |
There was a problem hiding this comment.
params.RewardDistributionBatchSize has a default value, we can reuse that var. We need adjust the value according to the performance test result.
unclezoro
approved these changes
Jan 27, 2022
yutianwu
reviewed
Mar 3, 2022
yutianwu
approved these changes
Mar 3, 2022
unclezoro
reviewed
Mar 4, 2022
app/config/config.go
Outdated
| @@ -544,6 +546,7 @@ func defaultUpgradeConfig() *UpgradeConfig { | |||
| BEP67Height: 1, | |||
| BEP70Height: 1, | |||
| LaunchBscUpgradeHeight: 1, | |||
| BEP128Height: 1, | |||
There was a problem hiding this comment.
Please set it to be MaxInt for the first time launch
unclezoro
requested changes
Mar 4, 2022
unclezoro
approved these changes
Mar 8, 2022
Merged
forcodedancing
added a commit
that referenced
this pull request
Mar 8, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
forcodedancing
added a commit
that referenced
this pull request
May 19, 2022
* sidechain staking reward distribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr tries to implement the staking reward distribution mechanism proposed in BEP128 - in short, staking reward will be distributed in normal blocks after breathe blocks.
Be noted, this pr will change the kafka message schema of distribution.
Rationale
As mentioned in BEP128, current reward distribution mechanism leads to a heavy load to breath blocks, and users' transactions/requests could be affected. Meanwhile, it could be also a bottleneck for further evolution of Binance Chain. Thus, we need to fix the issue and it will also benefit the evaluation of Binance Chain.
Example
N/A
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
No
Related issues
No