Merge pull request #492 from binance-chain/develop

Release v0.5.2

Gopkg.toml

@@ -42,7 +42,7 @@
 [[constraint]]
   name = "github.com/cosmos/cosmos-sdk"
   source = "github.com/binance-chain/bnc-cosmos-sdk"
-  version = "=v0.25.0-binance.9"
+  version = "=v0.25.0-binance.10"
 
 [[constraint]]
   name = "github.com/btcsuite/btcd"

plugins/dex/order/handler_test.go

@@ -127,7 +127,7 @@ func TestHandler_ValidateOrder_WrongPrice(t *testing.T) {
 
 	err = validateOrder(ctx, pairMapper, acc, msg)
 	require.Error(t, err)
-	require.Equal(t, fmt.Sprintf("price(%v) is not rounded to tickSize(%v)", msg.Price, pair.TickSize), err.Error())
+	require.Equal(t, fmt.Sprintf("price(%v) is not rounded to tickSize(%v)", msg.Price, pair.TickSize.ToInt64()), err.Error())
 }
 
 func TestHandler_ValidateOrder_WrongQuantity(t *testing.T) {
@@ -148,7 +148,7 @@ func TestHandler_ValidateOrder_WrongQuantity(t *testing.T) {
 
 	err = validateOrder(ctx, pairMapper, acc, msg)
 	require.Error(t, err)
-	require.Equal(t, fmt.Sprintf("quantity(%v) is not rounded to lotSize(%v)", msg.Quantity, pair.LotSize), err.Error())
+	require.Equal(t, fmt.Sprintf("quantity(%v) is not rounded to lotSize(%v)", msg.Quantity, pair.LotSize.ToInt64()), err.Error())
 }
 
 func TestHandler_ValidateOrder_Normal(t *testing.T) {

plugins/dex/order/msg_test.go

@@ -5,10 +5,10 @@ import (
 	"regexp"
 	"testing"
 
+	"github.com/binance-chain/node/common/testutils"
 	"github.com/spf13/viper"
 	"github.com/stretchr/testify/assert"
 
-	"github.com/tendermint/tendermint/libs/bech32"
 	rpcclient "github.com/tendermint/tendermint/rpc/client"
 
 	"github.com/cosmos/cosmos-sdk/client"
@@ -56,9 +56,7 @@ func TestIsValidTimeInForce(t *testing.T) {
 
 func TestNewOrderMsg_ValidateBasic(t *testing.T) {
 	assert := assert.New(t)
-	add, e := bech32.ConvertAndEncode(sdk.Bech32PrefixAccAddr, []byte("NEWORDERVALIDATE"))
-	acct, e := sdk.AccAddressFromBech32(add)
-	t.Log(e)
+	_, acct := testutils.PrivAndAddr()
 	msg := NewNewOrderMsg(acct, "addr-1", 1, "BTC.B_BNB", 355, 100)
 	assert.Nil(msg.ValidateBasic())
 	msg = NewNewOrderMsg(acct, "addr-1", 5, "BTC.B_BNB", 355, 100)