Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/export req #243

Merged
merged 2 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/twelve-mangos-scream.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@bnb-chain/greenfield-js-sdk': patch
---

fix: XML force convert array not object
13 changes: 11 additions & 2 deletions packages/chain-sdk/src/api/bucket.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ import { MsgCreateBucketSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgC
import { MsgDeleteBucketSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgDeleteBucket';
import { MsgMigrateBucketSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgMigrateBucket';
import { MsgUpdateBucketInfoSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgUpdateBucketInfo';
import { GetUserBucketsResponse, ReadQuotaResponse } from '@/types/spXML';
import {
GetSpListObjectsByBucketNameResponse,
GetUserBucketsResponse,
ReadQuotaResponse,
} from '@/types/spXML';
import {
getAuthorization,
getAuthorizationAuthTypeV2,
Expand Down Expand Up @@ -382,7 +386,12 @@ export class Bucket implements IBucket {
};
}

const xmlParser = new XMLParser();
const xmlParser = new XMLParser({
isArray: (tagName: string) => {
if (tagName === 'Buckets') return true;
return false;
},
});
const xmlData = await result.text();
const res = xmlParser.parse(xmlData) as GetUserBucketsResponse;

Expand Down
7 changes: 6 additions & 1 deletion packages/chain-sdk/src/api/objectt.ts
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,12 @@ export class Objectt implements IObject {
};
}

const xmlParser = new XMLParser();
const xmlParser = new XMLParser({
isArray: (tagName: string) => {
if (tagName === 'Objects') return true;
return false;
},
});
const xmlData = await result.text();
const res = xmlParser.parse(xmlData) as GetSpListObjectsByBucketNameResponse;

Expand Down