Feat/group api (#217)

* fix: Dynamic add and delete members string array * chore: Release zk crypto
bnb-chain · Aug 16, 2023 · 8d08848 · 8d08848
1 parent 9637ef1
commit 8d08848
Show file tree

Hide file tree

Showing 8 changed files with 108 additions and 15 deletions.
diff --git a/.changeset/large-jokes-fly.md b/.changeset/large-jokes-fly.md
@@ -0,0 +1,5 @@
+---
+'@bnb-chain/greenfield-js-sdk': patch
+---
+
+fix: Dynamic add and delete members string array
diff --git a/.changeset/pre.json b/.changeset/pre.json
@@ -6,7 +6,7 @@
     "@demo/nodejs": "0.0.5",
     "@bnb-chain/greenfield-js-sdk": "0.2.3",
     "@bnb-chain/greenfiled-file-handle": "0.2.0",
-    "@bnb-chain/zk-crypto": "0.0.1"
+    "@bnb-chain/greenfield-zk-crypto": "0.0.1"
   },
   "changesets": [
     "five-mice-whisper",
@@ -17,4 +17,4 @@
     "seven-toys-fry",
     "soft-phones-give"
   ]
-}
+}
diff --git a/.changeset/yellow-plums-cheat.md b/.changeset/yellow-plums-cheat.md
@@ -0,0 +1,5 @@
+---
+'@bnb-chain/greenfield-zk-crypto': patch
+---
+
+chore: Release
diff --git a/examples/nextjs/src/components/group/index.tsx b/examples/nextjs/src/components/group/index.tsx
@@ -2,6 +2,7 @@ import { CreateGroup } from './create';
 import { DeleteGroup } from './delete';
 import { GroupInfo } from './info';
 import { ListGroup } from './list';
+import { GroupUpdate } from './update';
 
 export const Group = () => {
   return (
@@ -14,6 +15,8 @@ export const Group = () => {
 
       <GroupInfo />
 
+      <GroupUpdate />
+
       <ListGroup />
     </div>
   );

diff --git a/examples/nextjs/src/components/group/update/index.tsx b/examples/nextjs/src/components/group/update/index.tsx
@@ -0,0 +1,52 @@
+import { client } from '@/client';
+import { useState } from 'react';
+import { zeroAddress } from 'viem';
+import { useAccount } from 'wagmi';
+
+export const GroupUpdate = () => {
+  const { address } = useAccount();
+  const [groupName, setGroupName] = useState('');
+
+  return (
+    <div>
+      <h3>group update</h3>
+      <input
+        placeholder="group name"
+        onChange={(e) => {
+          setGroupName(e.target.value);
+        }}
+      />
+      <button
+        onClick={async () => {
+          if (!address) return;
+
+          const updateGroupTx = await client.group.updateGroupMember({
+            operator: address,
+            groupOwner: address,
+            groupName: groupName,
+            membersToAdd: [],
+            membersToDelete: ['0x903904936a4328fac5477c0d96acf2E2bCaCD33d'],
+          });
+
+          const simulateInfo = await updateGroupTx.simulate({
+            denom: 'BNB',
+          });
+
+          console.log(simulateInfo);
+
+          const res = await updateGroupTx.broadcast({
+            denom: 'BNB',
+            gasLimit: Number(simulateInfo.gasLimit),
+            gasPrice: simulateInfo.gasPrice,
+            payer: address,
+            granter: '',
+          });
+
+          console.log('res', res);
+        }}
+      >
+        update group
+      </button>
+    </div>
+  );
+};
diff --git a/packages/chain-sdk/src/api/group.ts b/packages/chain-sdk/src/api/group.ts
@@ -2,7 +2,7 @@ import { MsgCreateGroupSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgCr
 import { MsgDeleteGroupSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgDeleteGroup';
 import { MsgLeaveGroupSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgLeaveGroup';
 import { MsgUpdateGroupExtraSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgUpdateGroupExtra';
-import { MsgUpdateGroupMemberSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgUpdateGroupMember';
+import { getMsgUpdateGroupMemberSDKTypeEIP712 } from '@/messages/greenfield/storage/MsgUpdateGroupMember';
 import { GRNToString, newBucketGRN, newGroupGRN, newObjectGRN } from '@/utils/grn';
 import {
   QueryGroupNFTResponse,
@@ -138,7 +138,10 @@ export class Group implements IGroup {
     return await this.basic.tx(
       MsgUpdateGroupMemberTypeUrl,
       msg.operator,
-      MsgUpdateGroupMemberSDKTypeEIP712,
+      getMsgUpdateGroupMemberSDKTypeEIP712({
+        membersToAdd: msg.membersToAdd,
+        membersToDelete: msg.membersToDelete,
+      }),
       MsgUpdateGroupMember.toSDK(msg),
       MsgUpdateGroupMember.encode(msg).finish(),
     );

diff --git a/packages/chain-sdk/src/messages/greenfield/storage/MsgUpdateGroupMember.ts b/packages/chain-sdk/src/messages/greenfield/storage/MsgUpdateGroupMember.ts
@@ -1,4 +1,29 @@
-export const MsgUpdateGroupMemberSDKTypeEIP712 = {
+export const getMsgUpdateGroupMemberSDKTypeEIP712 = ({
+  membersToAdd,
+  membersToDelete,
+}: {
+  membersToAdd: string[];
+  membersToDelete: string[];
+}) => {
+  const res = MsgUpdateGroupMemberSDKTypeEIP712;
+  if (membersToAdd.length > 0) {
+    res.Msg1.push({
+      name: 'members_to_add',
+      type: 'string[]',
+    });
+  }
+
+  if (membersToDelete.length > 0) {
+    res.Msg1.push({
+      name: 'members_to_delete',
+      type: 'string[]',
+    });
+  }
+
+  return res;
+};
+
+const MsgUpdateGroupMemberSDKTypeEIP712 = {
   Msg1: [
     {
       name: 'type',
@@ -16,13 +41,13 @@ export const MsgUpdateGroupMemberSDKTypeEIP712 = {
       name: 'group_name',
       type: 'string',
     },
-    {
-      name: 'members_to_add',
-      type: 'string[]',
-    },
-    {
-      name: 'members_to_delete',
-      type: 'string[]',
-    },
+    // {
+    //   name: 'members_to_add',
+    //   type: 'string[]',
+    // },
+    // {
+    //   name: 'members_to_delete',
+    //   type: 'string[]',
+    // },
   ],
 };
diff --git a/packages/zk-crypto/package.json b/packages/zk-crypto/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "@bnb-chain/zk-crypto",
+  "name": "@bnb-chain/greenfield-zk-crypto",
   "version": "0.0.2-alpha.0",
   "description": "Zk crypto wasm module",
   "scripts": {
@@ -36,4 +36,4 @@
     "webpack": "^5.88.1",
     "webpack-cli": "^5.1.4"
   }
-}
+}