Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Right now, the code skips validating the end of the pattern in MatchUnvalidated() if it finds that pattern has not matched. However, if we get to the end of the name and there is still pattern that is not "zero length", we don't need to validate that either.
Also add some unit tests to make sure we are skipping validation when we can.
Why
Speed up the code a bit by skipping more unnecessary validation.
Tests
I added a unit test specifically to see what errors are being detected whether validate is set to true or false.
When those tests are run on main, they show a single error:
This is capturing the fact that we got to the end of the name, had matched the whole way, but were unnecessarily doing additional validation instead of immediately returning false.