-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor kohya_gui parts #2017
refactor kohya_gui parts #2017
Conversation
This look awesome, I will merge it to a new branch based on dev to test it out and assess it. Looking forward to merge it to the dev branch |
I discovered a small issue... the stop training button no longer appear to actually stop the training... Probably something minor. Would you be able to attend to it? Otherwise everything look pretty much good to go with just one minor other bug I was able to attend to. The windows validation python script library call needed an adjustment to point to the new kohya_gui folder. EDIT: Nah, that stop issue was my own wrongdoing... I was on the wrong tab when I hit the stop training... so obviously it could not find the dreambooth process when what I tested was a LoRA ;-) OK, I will merge this to dev... Many thanks for this. Now I am thinking that all those _gui.py files in the root of the repo should probably move under the kohya_gui folder... What do you think? |
Thank you for all your hard work!
Yes we can move the wrapper frontends to the |
Recent updates have brought it almost synced with the original kohya's repo.
This PR splitting/refactoring the structure of the code a bit to make it more manageable/upstreamable.
And then, it's easy to support both the sd-webui extension and standalone script.
and this is a quick and dirty sd-webui extension wkpark/sd-scripts#1