Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#398 - tidy up queries #409

Merged
merged 12 commits into from
Mar 25, 2024
Merged

#398 - tidy up queries #409

merged 12 commits into from
Mar 25, 2024

Conversation

kamilpiech97
Copy link
Member

@kamilpiech97 kamilpiech97 commented Mar 20, 2024 •
edited
Loading

Should close #398.
Optimized some queries on dashboard and vacation requests page - removed some duplicated queries and cached some similar queries with laragear/cache-query.

@kamilpiech97
Merge branch 'main' into #398-tidy-up-queries
8f500dc 
# Conflicts:
#	app/Domain/DailySummaryRetriever.php
#	app/Domain/DashboardAggregator.php
#	app/Infrastructure/Http/Controllers/VacationRequestController.php
#	composer.lock
@kamilpiech97
- merged main
171d0ff
@kamilpiech97 kamilpiech97 marked this pull request as ready for review March 21, 2024 08:03
@kamilpiech97 kamilpiech97 requested a review from a team as a code owner March 21, 2024 08:03
EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't create request, because type of request are not fetch

image

image

EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Mar 22, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add key CACHE_QUERY_STORE to .env file?

@kamilpiech97
Copy link
Member Author

Should we add key CACHE_QUERY_STORE to .env file?

Added

@EwelinaSkrzypacz
Copy link
Member

I can't create request, because type of request are not fetch

image

image

It happens when I have APP_URL like localhost:8751 - I use this, because on localhost login by Google works - on blumilk environment the above error doesn't occur.

@kamilpiech97
Copy link
Member Author

I can't create request, because type of request are not fetch
image
image

It happens when I have APP_URL like localhost:8751 - I use this, because on localhost login by Google works - on blumilk environment the above error doesn't occur.

Did u try do that on other branch?
Maybe its general problem?

@EwelinaSkrzypacz
Copy link
Member

Okay, after removing 's' from https://toby.blumilk.localhost/ it works (login by Google and creating requests)

@kamilpiech97 kamilpiech97 merged commit eb00bd2 into main Mar 25, 2024
2 checks passed
@kamilpiech97 kamilpiech97 deleted the #398-tidy-up-queries branch March 25, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzysztofrewak krzysztofrewak krzysztofrewak approved these changes

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tidy up queries in dashboard
3 participants
@kamilpiech97 @EwelinaSkrzypacz @krzysztofrewak