fix double close #24
Open
fix double close #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklynch
requested changes
Oct 8, 2021
jklynch
requested changes
Oct 8, 2021
But if we make this change here then we should do the same for all of the other suitcases right? Maybe we can add the test and turn on the CI for the next round of releases? |
|
@gwbischof, did it work locally? |
mrakitin
approved these changes
Oct 8, 2021
Yep it worked locally. Also this fix has already been merged into the other suitcases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same fix that @tacaswell made on suitcase-jsonl.
See bluesky/suitcase-jsonl#19 (comment)