Fix quote & list padding not being pressable #7694
Merged
+12
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mozzius
commented
Feb 8, 2025
| @@ -267,7 +260,7 @@ export function MaybeFeedCard({view}: {view: AppBskyFeedDefs.GeneratorView}) { | |||
| <ContentHider modui={moderation?.ui('contentList')}> | |||
| <FeedSourceCard | |||
| feedUri={view.uri} | |||
| style={[pal.view, pal.border, styles.customFeedOuter]} | |||
| style={[a.border, t.atoms.border_contrast_medium, a.p_md, a.rounded_sm]} | |||
There was a problem hiding this comment.
I don't think the pal.view was needed, correct me if I'm wrong. We need to avoid unnecessary background colours for android perf
There was a problem hiding this comment.
Yea let's get rid of that. We used it for background colors in the past, but otherwise unnecessary.
|
haileyok
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote & list embeds have a problem with their padding, in that the pressable link area is contained within the padding, meaning the padding area is not clickable. Easiest to understand by just looking at the before/after of the pressable area
Test plan
Ensure padding area is now clickable
Ensure styles for these elements is otherwise the same
Here's a thread of different embeds: https://bsky.app/profile/samuel.bsky.team/post/3lhmznav6j22d