Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-1031] Add new followerRule to threadgate settings #7681

Merged
merged 7 commits into from
Feb 11, 2025

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Feb 6, 2025

Adds followersRule support to interaction settings. App view and dataplane are already deployed and working, so all that's left is the UI.

CleanShot 2025-02-06 at 21 53 55@2x
CleanShot 2025-02-06 at 21 53 10@2x
CleanShot 2025-02-06 at 21 48 40@2x
CleanShot 2025-02-06 at 21 40 30@2x

Copy link

github-actions bot commented Feb 6, 2025

Old size New size Diff
7.02 MB 7.02 MB 2.42 KB (0.03%)

Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, works perfectly. Filed #7692 separately.

My only suggestion is maybe disable this enormous CTA when the threadgate is enabled? What do you think? It's nbd to keep it if you disagree

Screenshot 2025-02-07 at 22 51 08

@pfrazee
Copy link
Collaborator

pfrazee commented Feb 8, 2025

Yeah actually let's remove that in that case

@arcalinea arcalinea temporarily deployed to eric/app-1031-add-followedby-threadgate-to-frontend - social-app PR #7681 February 11, 2025 17:26 — with Render Destroyed
@estrattonbailey
Copy link
Member Author

Discussed in Slack and decided to err on the side of increasing friction for following a user and then replying, if indeed the followedBy rule is in place.

@mozzius noting that since we show placeholder data from the cache here and get the threadgate from getPostThread, there is a slight flash of the Follow button rendering and then hiding.

I felt this was better than the alternative of not showing the Follow button and then showing it once the thread fully loaded, since that will affect the vast majority of posts, and the small regression here only affects posts with this threadgate enabled.

@arcalinea arcalinea temporarily deployed to eric/app-1031-add-followedby-threadgate-to-frontend - social-app PR #7681 February 11, 2025 17:29 — with Render Destroyed
@estrattonbailey
Copy link
Member Author

Also noting that initially I had reverted the profile shadow use that was in place to ensure the reply button responded to a follow from the post thread. But I reverted that again so that post -> profile -> follow -> back to post enables replies. I think this would be confusing otherwise.

@surfdude29
Copy link
Contributor

surfdude29 commented Feb 11, 2025

Sorry for jumping in here with one small point that just occurred to me: if you view a post that has the followedBy threadgate set on a feed (e.g. Discover or on someone's profile) on native and you don't follow the author, would the follow option be unavailable when tapping on the author's avatar, too? It's not quite as big and obvious a CTA, of course.

Edit: I guess this would only be a concern where someone sees that the comment icon is greyed out or taps on it and nothing happens, and then decides to try following the author directly from the feed to see if that lets them comment, rather than opening the post. So... maybe a rather niche scenario I'm imagining, actually 😅

@estrattonbailey
Copy link
Member Author

@surfdude29 no that's a good shout, maybe we should handle that case too. That also implies it should be hidden on the profile hover on web... I might need to double check other cases.

It's never simple, is it 😅

@mozzius
Copy link
Member

mozzius commented Feb 11, 2025

I don't mind it being present on the hover popover etc - I think that's fine. the big CTA was enough

Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button flash is fine, not too bad

@pfrazee pfrazee merged commit 459611c into main Feb 11, 2025
7 checks passed
@pfrazee pfrazee deleted the eric/app-1031-add-followedby-threadgate-to-frontend branch February 11, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants