Hack patch for testing OTA update crash behavior #4942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4942.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqv4vbrtq21c73d86lt0. |
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"dir","filePath":"node_modules/expo-modules-core","reasons":["expoAutolinkingIos","expoAutolinkingAndroid"],"hash":"9df71ac8c4a237da3d991ee0a66316611d55e78d"},{"type":"dir","filePath":"patches","reasons":["patchPackage"],"hash":"e2cee35d425489380293c880e297c36a4c411d90"}]Generated by PR labeler 🤖 |
mozzius
approved these changes
Aug 15, 2024
|
we do want to revert this prior to cutting a release. added a note to release tracker. |
estrattonbailey
added a commit
that referenced
this pull request
Aug 21, 2024
* origin/main: (50 commits) Add `list hidden` screen (#4958) Expose more methods, support disabled items (#4954) Expose more props from button (#4953) Fix orphaned feed slices, handle blocks (#4944) Tweak `expo-modules-core` hack patch (#4955) [Experiment] Always show bottom bar (#4946) Revert "[Video] Download videos" (#4945) Move global "Sign out" out of the current account row (#4941) Hack patch for testing OTA update crash behavior (#4942) [Video] Download videos (#4886) swap control files (#4936) [Embed] Starter pack embed embed (#4935) [Video] set audio category to ambient every time a new player is made (#4934) Add `/live/` to supported YouTube embed URLs (#4932) [Video] Try/catch video play/pause (#4930) Don't kick to login screen on network error (#4911) Remove .withProxy() calls (#4929) [Video] Audio duck off main thread (#4926) subclass agent to add setPersistSessionHandler (#4928) [Video] Fix crash when switching tabs (#4925) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
There's a crash that's happening when
reloadAsync()gets called byexpo-updates. This is coming from attempting to destructure a null pointer, whenever removing all of theSharedObjects inSharedObjectRegistry.clear().A little digging shows that the
deinitblock ofVideoPlayerruns afterclear()get's called. However, right nowclear()callsdict.removeAll()asynchronously inside of a separate queue from the main one. This is a small test to see if this helps to alievate the crashes. I don't consider this a production fix.Test Plan
Merge, let it build, and monitor for OTA crashes as we have been internally.