Appview: ensure takedowns on modlist authors always apply #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinivy
commented
Dec 6, 2024
Comment on lines
+161
to
+165
| const block = res.blocks[i] | ||
| blocks.set(pair.a, pair.b, { | ||
| blockUri: block.blockedBy || block.blocking || undefined, | ||
| blockListUri: block.blockedByList || block.blockingByList || undefined, | ||
| }) |
There was a problem hiding this comment.
May consider defensively assuming block might not exist, even though it should. Could log a warn or error in that case.
rafaelbsky
approved these changes
Dec 6, 2024
|
If I've understood correctly, would this fix bluesky-social/social-app#4999 and bluesky-social/social-app#6467? |
|
@surfdude29 yes, it should! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we apply moderation lists, we should always ensure the list creator is still active.