Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: fix detecting closure of some sessions (#4204) #4212

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Jan 31, 2025

Fixes #4204

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.49%. Comparing base (5cb5dc4) to head (bffc481).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocols/webrtc/peer_connection.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4212   +/-   ##
=======================================
  Coverage   56.48%   56.49%           
=======================================
  Files         202      202           
  Lines       20648    20656    +8     
=======================================
+ Hits        11663    11669    +6     
- Misses       8116     8118    +2     
  Partials      869      869           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the fix/webrtc-close branch 2 times, most recently from 0441205 to 7f33edd Compare February 1, 2025 12:37
@aler9 aler9 merged commit a1c6da8 into main Feb 1, 2025
8 checks passed
@aler9 aler9 deleted the fix/webrtc-close branch February 1, 2025 12:43
Copy link
Contributor

github-actions bot commented Feb 7, 2025

This issue is mentioned in release v1.11.3 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.11.2] - user session closed not detected anymore for webrtc stream
1 participant