Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp: support additional Enhanced-RTMP features (#3685) #4088

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 28, 2024

Fixes #3685

TODO

  • publish Opus tracks
  • [ ] read Opus tracks
  • proxy Opus tracks
  • publish AC-3 tracks
  • [ ] read AC-3 tracks
  • proxy AC-3 tracks
  • publish multiple video tracks
  • publish multiple audio tracks
  • tests

@aler9 aler9 force-pushed the feature/ertmp branch 3 times, most recently from b5374d6 to fdaaa6e Compare December 29, 2024 17:42
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 61.38996% with 400 lines in your changes missing coverage. Please review.

Project coverage is 56.02%. Comparing base (f216043) to head (f32f28b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/protocols/rtmp/reader.go 43.19% 207 Missing and 31 partials ⚠️
internal/protocols/rtmp/to_stream.go 0.00% 105 Missing and 1 partial ⚠️
...tocols/rtmp/message/msg_video_ex_sequence_start.go 67.85% 18 Missing and 9 partials ⚠️
...tocols/rtmp/message/msg_audio_ex_sequence_start.go 84.74% 6 Missing and 3 partials ⚠️
.../protocols/rtmp/message/msg_video_ex_multitrack.go 91.07% 4 Missing and 1 partial ⚠️
...s/rtmp/message/msg_audio_ex_multichannel_config.go 95.31% 3 Missing ⚠️
.../protocols/rtmp/message/msg_audio_ex_multitrack.go 94.64% 2 Missing and 1 partial ⚠️
internal/protocols/rtmp/message/opus_id_header.go 93.18% 2 Missing and 1 partial ⚠️
...rotocols/rtmp/message/msg_video_ex_sequence_end.go 81.81% 2 Missing ⚠️
internal/protocols/rtmp/message/reader.go 94.44% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4088      +/-   ##
==========================================
+ Coverage   55.60%   56.02%   +0.42%     
==========================================
  Files         193      199       +6     
  Lines       19851    20425     +574     
==========================================
+ Hits        11038    11444     +406     
- Misses       7965     8121     +156     
- Partials      848      860      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 force-pushed the feature/ertmp branch 17 times, most recently from e2c38c9 to b3925e0 Compare January 1, 2025 12:47
new features:
* support publishing Opus and AC-3 tracks
* support publishing more than 2 tracks. This is compatible with OBS multitrack video and OBS VOD audio track
@aler9 aler9 merged commit 8cbbbc0 into main Jan 2, 2025
8 checks passed
@aler9 aler9 deleted the feature/ertmp branch January 2, 2025 11:44
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This issue is mentioned in release v1.11.0 🚀
Check out the entire changelog by clicking here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Enhanced RTMP v2
1 participant