Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python 3.10 compatibility #14

Merged
merged 2 commits into from
Jan 2, 2023

Conversation

awsr
Copy link
Contributor

@awsr awsr commented Nov 14, 2022

Force some values to int in order to prevent TypeError caused by changes to Python 3.10. (Most likely caused by python/cpython#82180)

@blueaxis
Copy link
Owner

Do you have the build file for this? The current build file I have doesn't work with this branch

@awsr
Copy link
Contributor Author

awsr commented Dec 17, 2022

I don't have a build file because I didn't even notice the main.spec file in the release assets until just now. I've just been running main.py directly from a batch file.
Is it giving a specific error or does it just not work with other branches?

@awsr
Copy link
Contributor Author

awsr commented Dec 17, 2022

I have also considered including the following addition to README.md before the "System Requirements" section to remind people to get the correct version of tesserocr if developing on Windows:

#### For Developers on Windows
*Before installing the requirements*, you must download a [pre-compiled build of tesserocr](https://github.com/simonflueckiger/tesserocr-windows_build/releases) and install it: `pip install <package_name>.whl`

@blueaxis
Copy link
Owner

I don't think this is an issue on tesseract. It might be due to torch which only added 3.10 support last year

@blueaxis blueaxis changed the base branch from main to dev/python-3.10 January 2, 2023 13:01
@blueaxis
Copy link
Owner

blueaxis commented Jan 2, 2023

Merging this on a dev branch, since I can't build the app with python 3.10

@blueaxis blueaxis merged commit 505b8e2 into blueaxis:dev/python-3.10 Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants