This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
Add Schema name while converting to connect schema. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sschatts any chance we could get this committed/published to Maven central? |
mike9005
approved these changes
Jul 25, 2019
|
@mike9005 thx for approval! Any chance we can get this merged/released into maven central soon 🤞 |
|
@criccomini yeah absolutely - we'll look at that in our next sprint |
|
We will post here once it is released in Maven central! Thanks for the contribution. |
|
Thanks so much! Interactions like this are what make open source so great. :D |
tveon
pushed a commit
to tveon/kafka-connect-protobuf-converter
that referenced
this pull request
Feb 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We are implementing a Kafka Source Connector, in which we are using kafka-connect-protobuf-converter to convert protobuf to connect Schema (in order to generate the SourceRecord). We are seeing an error "org.apache.avro.SchemaParseException: Can't redefine: io.confluent.connect.avro.ConnectDefault" when this connect schema is converted to avro via schema-registry. The error seems to be because of the missing name for Struct Schema. If a Schema name is not provided then a default name is considered. And if there is an embedded Struct schema, then it will try to use the same default name to both and fails to redefine.
I have added a fix to this PR, that will set the Schema name for (Type: Struct) that will further fix this error.