doc(primitives): Add docs to optimism
InvalidTransaction
errors.
#884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds short-term documentation to the
optimism
variants of theInvalidTransaction
error, which are bubbled up intoHalt::FailedDeposit
by theoptimism
handlers in therevm
crate, requested in #883.If requested, we can follow this up with a reimagined handling of these special cases to reduce ambiguity in the failed deposit path.
Resources for reviewers
op-geth
state transition code: https://github.com/ethereum-optimism/op-geth/blob/25fd986a27b206b8454b2e9ceb4b699a238974ed/core/state_transition.go#L397-L417