Fix error message for LackOfFundForMaxFee #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
reviewed
Nov 10, 2023
crates/primitives/src/result.rs
Outdated
| @@ -180,7 +180,7 @@ pub enum InvalidTransaction { | |||
| RejectCallerWithCode, | |||
| /// Transaction account does not have enough amount of ether to cover transferred value and gas_limit*gas_price. | |||
| LackOfFundForMaxFee { | |||
| fee: u64, | |||
| fee: U256, | |||
There was a problem hiding this comment.
Could you make them as Box<U256> it will reduce the size of the type, and balance too?
rakita
approved these changes
Nov 10, 2023
|
After changing the field to the Box i sow that optimism downcasted fee to the u64 so this PR even fixes that |
|
Will ignore fmt error, in local or CL logs it is not showing that anything is wrong |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning the fee for a transaction, the LackOfFundForMaxFee error currently returns gas_limit. This PR fixes that.