chore: Loop call stack #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is so exciting! I really like the way you managed the shared memory by taking it and replacing with an empty one. |
Yeah, that is one of benefits of loop calls! Will circle back to your PR, as we now have this new mechanism |
Closed
This was referenced Feb 4, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the recursive calls that we had to the loop call and interpreter stack.
This fully removes the possibility of problematic OS stack overflow that we had, it allows easier sharing of the shared context (As in memory, and removes lifetime from Interpreter) and better control over the call stack.
It allows easier the introduction of the handler for that part of the code and performance stayed the same