Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optional coinbase tip #625

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

clabby
Copy link
Contributor

@clabby clabby commented Aug 22, 2023

Overview

Adds a new feature flag, optional_coinbase_tip CfgEnv option, disable_coinbase_tip, that allows for disabling the tip to coinbase during transaction finalization. This option will be used in https://github.com/anton-rs/op-reth to support the Regolith hardfork.

@rakita
Copy link
Member

rakita commented Aug 22, 2023

Can you do it without a feature flag, this option can be generally useful.

And (maybe not related) but is this line okay to stay, loading coinbase address as warm if coinbase does not receive a fee:

// load coinbase
// EIP-3651: Warm COINBASE. Starts the `COINBASE` address warm
if GSPEC::enabled(SHANGHAI) {
self.data
.journaled_state
.initial_account_load(self.data.env.block.coinbase, &[], self.data.db)
.map_err(EVMError::Database)?;
}

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rakita rakita merged commit 0028193 into bluealloy:main Aug 22, 2023
@clabby clabby deleted the cl/optional-coinbase-tip branch August 23, 2023 00:07
mikelodder7 pushed a commit to LIT-Protocol/revm that referenced this pull request Sep 12, 2023
* feat: Optional coinbase tip

* Remove feature flag, retain optionality
Evalir pushed a commit to Evalir/revm that referenced this pull request Sep 14, 2023
* feat: Optional coinbase tip

* Remove feature flag, retain optionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants