fix: call create_end for all code paths

[Wodann]

No description provided.

[rakita]

This is not exactly the pattern used elsewhere

revm/crates/revm/src/evm_impl.rs

Lines 405 to 412 in 5d6ecd0

	if INSPECT {
	let (ret, address, gas, out) = self.inspector.create(&mut self.data, inputs);
	if ret != InstructionResult::Continue {
	return self
	.inspector
	.create_end(&mut self.data, inputs, ret, address, gas, out);
	}
	}

by default create_end would return ::Continue

[Wodann]

Isn't Inspector::create_end supposed to be called for every possible reason the create function might end?

[Wodann]

by default create_end would return ::Continue

And doesn't the default implementation of create_end return ret?

revm/crates/revm/src/inspector.rs

Lines 123 to 133 in 5d6ecd0

	fn create_end(
	&mut self,
	_data: &mut EVMData<'_, DB>,
	_inputs: &CreateInputs,
	ret: InstructionResult,
	address: Option<B160>,
	remaining_gas: Gas,
	out: Bytes,
	) -> (InstructionResult, Option<B160>, Gas, Bytes) {
	(ret, address, remaining_gas, out)
	}

[Wodann]

I made sure create_end is now called for all return code paths

[rakita]

nice pattern!