Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(revme): use Osaka for state test results #1844

Closed
wants to merge 3 commits into from
Closed

fix(revme): use Osaka for state test results #1844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63b1091
fix(revme): use Osaka for state test results
Rjected Nov 1, 2024
d8eff25
fix usage of prague
Rjected Nov 1, 2024
d9f03b9
add prague as well
Rjected Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bins/revme/src/cmd/eofvalidation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
mod test_suite;

pub use test_suite::{PragueTestResult, TestResult, TestSuite, TestUnit, TestVector};
pub use test_suite::{OsakaTestResult, TestResult, TestSuite, TestUnit, TestVector};

use crate::{cmd::Error, dir_utils::find_all_json_tests};
use clap::Parser;
Expand Down Expand Up @@ -82,12 +82,12 @@ pub fn run_test(path: &Path) -> Result<(), Error> {
Some(CodeType::ReturnOrStop)
};
let res = validate_raw_eof_inner(test_vector.code.clone(), kind);
if res.is_ok() != test_vector.results.prague.result {
if res.is_ok() != test_vector.results.osaka.result {
println!(
"\nTest failed: {} - {}\nresult:{:?}\nrevm err_result:{:#?}\nbytes:{:?}\n",
name,
vector_name,
test_vector.results.prague,
test_vector.results.osaka,
res.as_ref().err(),
test_vector.code
);
Expand Down
6 changes: 4 additions & 2 deletions bins/revme/src/cmd/eofvalidation/test_suite.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,14 @@ pub struct TestUnit {
pub struct TestVector {
pub code: Bytes,
pub container_kind: Option<String>,
pub results: PragueTestResult,
pub results: OsakaTestResult,
}

#[derive(Debug, PartialEq, Eq, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct PragueTestResult {
pub struct OsakaTestResult {
#[serde(rename = "Osaka")]
pub osaka: TestResult,
#[serde(rename = "Prague")]
pub prague: TestResult,
}
Expand Down
Loading