Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gas cost calculation #1166

Merged
merged 4 commits into from
Mar 8, 2024
Merged

fix: gas cost calculation #1166

merged 4 commits into from
Mar 8, 2024

Conversation

Wodann
Copy link
Contributor

@Wodann Wodann commented Mar 7, 2024

A bug was introduced in the last gas cost calculation in this commit. This PR fixes it.

@Wodann Wodann mentioned this pull request Mar 7, 2024
Merged
3 tasks
mattsse
mattsse requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, smol naming nit to make a bit more clear that this is the previously tracked remaining gas

Wodann and others added 2 commits March 7, 2024 18:30
@Wodann @mattsse
Update crates/revm/src/inspector/gas.rs
0a68ec8 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@Wodann @mattsse
Update crates/revm/src/inspector/gas.rs
65b2efc 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@Wodann Wodann requested a review from mattsse March 8, 2024 00:30
mattsse
mattsse approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending fmt

gakonst
gakonst approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Wodann pls fmt and we can send

@Wodann
Copy link
Contributor Author

Wodann commented Mar 8, 2024

Formatting done. Thanks!

@rakita rakita merged commit 1fa2d26 into bluealloy:main Mar 8, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
Merged
fubuloubu pushed a commit to ApeWorX/revm that referenced this pull request Apr 11, 2024
@Wodann @fubuloubu
fix: gas cost calculation (bluealloy#1166)
12ac70c 
* fix: gas cost calculation

* Update crates/revm/src/inspector/gas.rs

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* Update crates/revm/src/inspector/gas.rs

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* fix: formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

@gakonst gakonst gakonst approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Wodann @rakita @gakonst @mattsse