-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Burntpix criterion bench #1004
Burntpix criterion bench #1004
Conversation
crates/revm/benches/burntpix/mod.rs
Outdated
interface IBURNTPIX { | ||
function run( uint32 seed, uint256 iterations) returns (string); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice touch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good first iteration! Left nitpicks to clean it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Related to #986.
Hi @rakita ,
I tried to follow the criterion benches and implement the Burntpix bench from there.
I tried to find the cleanest way to initialise the REVM with empty db from some static genesis allocations, please tell me if you got a better idea :)
Waiting for your feedback !
Thanks a lot!