Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #337 Added a separate method to sign transaction bytes #342

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

satran004
Copy link
Member

@satran004 satran004 commented Nov 6, 2023

  • New methods have been added that avoid de-serializing the full transaction bytes, thereby preventing any compatibility issues.
 public byte[] sign(byte[] transactionBytes, SecretKey secretKey)
public byte[] sign(byte[] transactionBytes, HDKeyPair hdKeyPair)
  • Old sign methods are delegating to above new methods for tx signing

@satran004 satran004 marked this pull request as draft November 6, 2023 08:22
@satran004 satran004 marked this pull request as ready for review January 24, 2024 11:34
@satran004
Copy link
Member Author

@Sotatek-HuyLe3 Please check TransactionBytes class in this PR. We can use this class or something like this in Yaci to fix incorrect metadata cbor.

@Sotatek-HuyLe3a
Copy link
Collaborator

Thanks, this class could be useful for fixing incorrect metadata cbor.

@satran004 satran004 merged commit d320bf6 into master Jan 26, 2024
4 checks passed
@satran004 satran004 deleted the fix_337 branch January 26, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants