Set custom error message inside connection close method for unauthorised client #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamncasey
reviewed
Nov 26, 2021
libamqpprox/amqpprox_connector.cpp
Outdated
| inline void | ||
| Connector::synthesizeMessage(TMethod &replyMethod, | ||
| bool sendToIngressSide, | ||
| uint64_t code /* = Reply::Codes::reply_success */, |
There was a problem hiding this comment.
Can we always use code and text and remove the templated argument TReply here? I don't see the benefit of it
libamqpprox/amqpprox_connector.cpp
Outdated
| void Connector::synthesizeCloseAuthError(bool sendToIngressSide) | ||
| void Connector::synthesizeCustomCloseError(bool sendToIngressSide, | ||
| uint16_t code, | ||
| const std::string_view &text) |
There was a problem hiding this comment.
Suggested change
| const std::string_view &text) | |
| std::string_view text) |
I believe it's normal to pass string_view by value since copying them is very cheap.
adamncasey
approved these changes
Nov 26, 2021
371cd8d to
ea61fbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy can also be configured to use external http service to authenticate clients. But currently, if the external auth service fail to authenticate client, proxy will close the client connection with default message "ERROR: Not authorized by amqpprox proxy". It will be difficult for that client to debug the actual problem in that case. So this PR will propagate the reason, which proxy got from the external http service to the client. And client will immediately be able to know the actual reason in such cases.