dependency issues #1848
dependency issues #1848
Conversation
|
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: e5c7d43 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/614509d9e4c4240007e25406 😎 Browse the preview: https://deploy-preview-1848--dev-storybook-bloom.netlify.app |
|
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: e5c7d43 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/614509d903999a00075e05d0 😎 Browse the preview: https://deploy-preview-1848--dev-partners-bloom.netlify.app |
|
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: e5c7d43 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/614509d91db2a20008c2c5cf 😎 Browse the preview: https://deploy-preview-1848--dev-bloom.netlify.app |
| @@ -66,7 +66,6 @@ export function getColDefs(maxHouseholdSize: number, countyCode: string) { | |||
| width: 150, | |||
| minWidth: 120, | |||
| pinned: "left", | |||
| type: "leftAligned", | |||
There was a problem hiding this comment.
No longer exists and is default behavior anyway
| @@ -1,12 +1,8 @@ | |||
| import "@testing-library/jest-dom/extend-expect" | |||
|
|
|||
| import { configure } from "enzyme" | |||
There was a problem hiding this comment.
We weren't actually using enzyme anymore
| @@ -1,3 +1,5 @@ | |||
| @use "sass:math"; | |||
There was a problem hiding this comment.
Changes here needed from the ag-grid update (the old division way is deprecated now)
| swr@^0.5.5: | ||
| version "0.5.5" | ||
| resolved "https://registry.yarnpkg.com/swr/-/swr-0.5.5.tgz#c72c1615765f33570a16bbb13699e3ac87eaaa3a" | ||
| integrity sha512-u4mUorK9Ipt+6LEITvWRWiRWAQjAysI6cHxbMmMV1dIdDzxMnswWo1CyGoyBHXX91CchxcuoqgFZ/ycx+YfhCA== | ||
| dependencies: | ||
| dequal "2.0.2" | ||
|
|
||
| swr@^1.0.1: |
There was a problem hiding this comment.
I wonder how we still have two different versions of SWR? Should be the same one used for partners and public, right?
There was a problem hiding this comment.
Hmmmmmm that is weird! I'll take a look, thanks for noticing :)
* upgrade ag-grid * upgrade swr * upgrade accordion * upgrade react-focus-lock * add missing storybook peers, remove enzyme * missing peer on babel * minor update to use existing check for defaultUnit Co-authored-by: Sean Albert <smabert@gmail.com>
Our dependency warnings on fresh install went from 3 --> 23 after the tailwind/node/etc upgrade. I think we just missed a number of packages that also needed to be upgraded as we moved to React 17. Upgraded the packages I could which involved some tiny code updates in some places, I commented on all of them.
After this PR we have 5 warnings remaining, 4 of which we cannot fix ourselves. They are:
warning "workspace-aggregator-e0d01dfa-ee0d-47ef-8d50-0f1c5d0df64e > @bloom-housing/ui-components > react-text-mask@5.4.3" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".warning "workspace-aggregator-e0d01dfa-ee0d-47ef-8d50-0f1c5d0df64e > @bloom-housing/ui-components > @storybook/api > @reach/router@1.3.4" has incorrect peer dependency "react@15.x || 16.x || 16.4.0-alpha.0911da3".warning "workspace-aggregator-e0d01dfa-ee0d-47ef-8d50-0f1c5d0df64e > @bloom-housing/ui-components > @storybook/api > @reach/router@1.3.4" has incorrect peer dependency "react-dom@15.x || 16.x || 16.4.0-alpha.0911da3".warning "workspace-aggregator-e0d01dfa-ee0d-47ef-8d50-0f1c5d0df64e > @bloom-housing/ui-components > @storybook/api > @reach/router > create-react-context@0.3.0" has incorrect peer dependency "react@^0.14.0 || ^15.0.0 || ^16.0.0".warning "workspace-aggregator-e0d01dfa-ee0d-47ef-8d50-0f1c5d0df64e > @bloom-housing/ui-components > @storybook/react > @storybook/react-docgen-typescript-plugin > react-docgen-typescript@2.1.0" has incorrect peer dependency "typescript@>= 4.3.x".To test you can fresh
yarn installon dev and then on this branch!