Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.37.6 #2572

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Release v1.37.6 #2572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42c1a96
don't throw on "Too many requests" error from 3rd-party APIs
tom2drum Feb 6, 2025
eeeadb1
don't trap focus and block scroll in AuthModal
tom2drum Feb 13, 2025
efa17a9
update paths for 3rd party resources
tom2drum Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/api/resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ export const RESOURCES = {
filterFields: [],
},
address_xstar_score: {
path: '/api/v2/proxy/xname/addresses/:hash',
path: '/api/v2/proxy/3rdparty/xname/addresses/:hash',
pathParams: [ 'hash' as const ],
},

Expand All @@ -626,7 +626,7 @@ export const RESOURCES = {
pathParams: [ 'hash' as const, 'method' as const ],
},
contract_solidity_scan_report: {
path: '/api/v2/smart-contracts/:hash/solidityscan-report',
path: '/api/v2/proxy/3dparty/solidityscan/smart-contracts/:hash/report',
pathParams: [ 'hash' as const ],
},
contract_security_audits: {
Expand Down Expand Up @@ -1042,16 +1042,16 @@ export const RESOURCES = {

// NOVES-FI
noves_transaction: {
path: '/api/v2/proxy/noves-fi/transactions/:hash',
path: '/api/v2/proxy/3rdparty/noves-fi/transactions/:hash',
pathParams: [ 'hash' as const ],
},
noves_address_history: {
path: '/api/v2/proxy/noves-fi/addresses/:address/transactions',
path: '/api/v2/proxy/3rdparty/noves-fi/addresses/:address/transactions',
pathParams: [ 'address' as const ],
filterFields: [],
},
noves_describe_txs: {
path: '/api/v2/proxy/noves-fi/transaction-descriptions',
path: '/api/v2/proxy/3rdparty/noves-fi/transaction-descriptions',
},

// USER OPS
Expand Down
22 changes: 19 additions & 3 deletions lib/api/useQueryClientConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,26 @@ export default function useQueryClientConfig() {
queries: {
refetchOnWindowFocus: false,
retry,
throwOnError: (error) => {
throwOnError: (error, query) => {
const status = getErrorObjStatusCode(error);
// don't catch error for "Too many requests" response
return status === 429;

// we don't catch error only for "Too many requests" response
if (status !== 429) {
return false;
}

const EXTERNAL_API_RESOURCES = [
'safe_transaction_api',
'contract_solidity_scan_report',
'address_xstar_score',
'noves_transaction',
'noves_address_history',
'noves_describe_txs',
'gas_hawk_saving_potential',
];
const isExternalApiResource = EXTERNAL_API_RESOURCES.some((resource) => query.queryKey[0] === resource);

return !isExternalApiResource;
},
},
},
Expand Down
2 changes: 1 addition & 1 deletion ui/snippets/auth/AuthModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ const AuthModal = ({ initialScreen, onClose, mixpanelConfig, closeOnError }: Pro
}

return (
<Modal isOpen onClose={ onModalClose } size={{ base: 'full', lg: 'sm' }}>
<Modal isOpen onClose={ onModalClose } size={{ base: 'full', lg: 'sm' }} trapFocus={ false } blockScrollOnMount={ false }>
<ModalOverlay/>
<ModalContent p={ 6 } maxW={{ lg: '400px' }}>
<ModalHeader fontWeight="500" textStyle="h3" mb={ 2 } display="flex" alignItems="center" columnGap={ 2 }>
Expand Down
Loading