Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ad banner to 404 page #1967

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add Ad banner to 404 page #1967

merged 1 commit into from
Jun 10, 2024

Conversation

isstuev
Copy link
Collaborator

@isstuev isstuev commented May 29, 2024

Description and Related Issue(s)

resolves #1799

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

@isstuev isstuev requested a review from tom2drum May 29, 2024 14:46
@isstuev isstuev marked this pull request as ready for review May 29, 2024 14:46
@github-actions github-actions bot added the enhancement New feature or request label May 29, 2024
tom2drum
tom2drum approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@tom2drum tom2drum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really clear why the code of the banner content was moved to a separate component, but okay.

@isstuev isstuev merged commit c20b7f8 into main Jun 10, 2024
12 checks passed
@isstuev isstuev deleted the fe-1799 branch June 10, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Ad banner to 404 page
2 participants
@isstuev @tom2drum