Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load categories from config and improve app sorting #1545

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Load categories from config and improve app sorting #1545

merged 6 commits into from
Jan 30, 2024

Conversation

maxaleks
Copy link
Contributor

Resolves #1498

  1. added a new ENV: NEXT_PUBLIC_MARKETPLACE_CATEGORIES_URL
  2. made loading categories from a separate config file
  3. improved app sorting

@maxaleks maxaleks requested review from tom2drum and isstuev January 26, 2024 16:49
@maxaleks maxaleks linked an issue Jan 26, 2024 that may be closed by this pull request
Marketplace sorting #1498
Closed
tom2drum
tom2drum requested changes Jan 29, 2024
View reviewed changes
configs/app/features/index.ts Outdated Show resolved Hide resolved
deploy/tools/envs-validator/schema.ts Show resolved Hide resolved
docs/ENVS.md Outdated Show resolved Hide resolved
ui/marketplace/useMarketplaceCategories.tsx Outdated Show resolved Hide resolved
ui/marketplace/useMarketplaceCategories.tsx Outdated Show resolved Hide resolved
ui/marketplace/useMarketplace.tsx Outdated Show resolved Hide resolved
maxaleks and others added 3 commits January 29, 2024 14:18
@maxaleks maxaleks requested a review from tom2drum January 29, 2024 15:08
@tom2drum
Copy link
Collaborator

Can we make the tab skeleton resemble real tabs more? For instance, by adding additional tabs and increasing their width.

image

Base automatically changed from category-tabs to main January 30, 2024 13:58
@maxaleks maxaleks merged commit 4374a6f into main Jan 30, 2024
6 checks passed
@maxaleks maxaleks deleted the improve-marketplace-sorting branch January 30, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom2drum tom2drum tom2drum approved these changes

@isstuev isstuev Awaiting requested review from isstuev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Marketplace sorting
2 participants
@maxaleks @tom2drum