Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx logs: "Contract must be verified" message shown for the already verified contract in Tx logs #1268

Closed
ulyanas opened this issue Oct 8, 2023 · 2 comments · Fixed by #1286
Closed

Tx logs: "Contract must be verified" message shown for the already verified contract in Tx logs #1268

ulyanas opened this issue Oct 8, 2023 · 2 comments · Fixed by #1286
Assignees
@tom2drum
Labels
bug Something isn't working v1.15.0 Release v1.15.0

Comments

@ulyanas
Copy link

ulyanas commented Oct 8, 2023 •
edited
Loading

https://eth.blockscout.com/tx/0x5ad65dfa90672c50d44d1e44f0db545fb337aa3da9656a5768ec163caa9d3dd5?tab=logs

"Contract must be verified" message shown for the already verified contract in Tx logs.

Image

Steps:

  1. Open logs for a tx with unverified contract
  2. Verify the contract
  3. Open logs again

Result:

  • "Contract must be verified" message shown for the already verified contract in Tx logs.
  • Data is not decoded

Should be:
Logs should be decoded for a tx involving verified contracts
@ulyanas ulyanas added the bug Something isn't working label Oct 8, 2023
@isstuev
Copy link
Collaborator

isstuev commented Oct 8, 2023

the decoded status was taken from the API response, all the records except the first one have "decoded: null" property, what to show in that case?

@isstuev isstuev added the need info Waiting for more information from issue author label Oct 8, 2023
@NikitaSavik NikitaSavik removed the need info Waiting for more information from issue author label Oct 9, 2023
@NikitaSavik
Copy link
Contributor

Decided: remove " To see accurate...." notification if contract is verified, but events not decoded

@tom2drum tom2drum self-assigned this Oct 12, 2023
tom2drum added a commit that referenced this issue Oct 12, 2023
@tom2drum
Tx logs: "Contract must be verified" message shown for the already ve…
8c43c8b 
…rified contract in Tx logs

Fixes #1268
@tom2drum tom2drum mentioned this issue Oct 12, 2023
Merged
tom2drum added a commit that referenced this issue Oct 16, 2023
@tom2drum
Tx logs: "Contract must be verified" message shown for the already ve… (
3b49f1d 
#1286)

Tx logs: "Contract must be verified" message shown for the already verified contract in Tx logs

Fixes #1268
@github-actions github-actions bot added pre-release Tasks in pre-release right now v1.15.0 Release v1.15.0 and removed pre-release Tasks in pre-release right now labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tom2drum tom2drum

Labels
bug Something isn't working v1.15.0 Release v1.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tx logs: "Contract must be verified" message shown for the already ve… blockscout/frontend
4 participants
@NikitaSavik @ulyanas @tom2drum @isstuev