fix(cicd): update tag extractor to support prereleases #1218
Conversation
|
Warning Rate limit exceeded@sevenzing has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 21 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe pull request modifies the GitHub Actions workflow configuration for Docker build and push, specifically updating the regular expression pattern for tag matching. The new regex adheres to semantic versioning (semver) rules, allowing for optional pre-release and build metadata segments. This change enhances the flexibility of version matching by capturing a broader range of version formats. Additionally, the logic for extracting tag names has been refined to utilize new output groups from the regex step, defining variables for Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/_docker-build-push.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: Docker build and docker push / build-and-push
- GitHub Check: Docker build and docker push / build-and-push
- GitHub Check: Unit, doc and integration tests
- GitHub Check: Unit, doc and integration tests
- GitHub Check: Linting / lint
- GitHub Check: Unit, doc and integration tests
- GitHub Check: Unit, doc and integration tests
- GitHub Check: Unit, doc and integration tests
- GitHub Check: Unit, doc and integration tests
- GitHub Check: Unit, doc and integration tests
|
Do we also want to push swagger for pre releases? |
9e9f245 to
fb22bf8
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/_docker-build-push.yml (1)
57-71: Consider enhancing the tagging strategy for better version management.While the current implementation is functional, consider these improvements:
- Add major version tags (e.g.,
v2) for easier version pinning- Add minor version tags (e.g.,
v2.4) for more granular control- Consider adding a
stabletag for the latest non-prerelease versionHere's how you could enhance the tag extraction:
if [[ -n "$version" ]]; then + # Extract major and minor versions + major=$(echo "$version" | cut -d. -f1) + minor=$(echo "$version" | cut -d. -f1,2) if [[ -n "$prerelease" ]]; then - echo "tags=${{ env.IMAGE_NAME }}:$version" >> $GITHUB_OUTPUT + echo "tags=${{ env.IMAGE_NAME }}:$version,${{ env.IMAGE_NAME }}:$major-next,${{ env.IMAGE_NAME }}:$minor-next" >> $GITHUB_OUTPUT else - echo "tags=${{ env.IMAGE_NAME }}:$version, ${{ env.IMAGE_NAME }}:latest" >> $GITHUB_OUTPUT + echo "tags=${{ env.IMAGE_NAME }}:$version,${{ env.IMAGE_NAME }}:$major,${{ env.IMAGE_NAME }}:$minor,${{ env.IMAGE_NAME }}:latest,${{ env.IMAGE_NAME }}:stable" >> $GITHUB_OUTPUT fi
|
added semver regex to push-swagger job |
currently we only support tags like
stats/v1.1.1. we also want to support tags likestats/v2.4.0-alpha.0to produce prelease versionv2.4.0-alpha.0Summary by CodeRabbit