Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.35.5-0.0.1: [feature] Adds Tally wallet support #749

Merged
merged 1 commit into from
Dec 1, 2021
Merged

1.35.5-0.0.1: [feature] Adds Tally wallet support #749

merged 1 commit into from
Dec 1, 2021

Conversation

greg-nagy
Copy link

@greg-nagy greg-nagy commented Nov 30, 2021

Description

This PR implements the integration of the Tally wallet

Constraints

  • Currently we don't have a published version of the wallet, so the integration can only be tested against a local build of the wallet
    • See the quickstart for the extension repo.
    • The window provider is behind a feature flag for now.
      To enableisTallyWindowProviderEnabled has to set to true in the local storage on the given page.
  • The wallet is in read only mode as of now
  • We support only mainnet currently
  • You need to enter an address to use the integration

Demo

We have created a demo based on your official demo app to verify if the changes are working as intended.
To set up the demo:

git clone https://github.com/tallycash/tally-dapp-integration-samples.git
cd tally-dapp-integration-samples/onboard-react-demo/
yarn install 
yarn start

‼️ Then enable the integration set the isTallyWindowProviderEnabled flag to true in the local storage on https://localhost:3000 through the devtools. ‼️

Checklist

  • The version field in package.json is incremented following semantic versioning
  • The box that allows repo maintainers to update this PR is checked

Tried to enable this, but could not find this option anywhere. Probably because of this isaacs/github#1681
If this is a blocker, then happy to move this PR into a private fork. - Greg

  • I tested locally to make sure this feature/fix works
  • This PR passes the Circle CI checks

Pictures of the working demo

CleanShot 2021-11-30 at 14 33 12

CleanShot 2021-11-30 at 14 29 20

CleanShot 2021-11-30 at 14 28 53

Closes tahowallet/extension#479

@greg-nagy greg-nagy marked this pull request as draft November 30, 2021 13:37
@greg-nagy greg-nagy marked this pull request as ready for review November 30, 2021 13:41
@taylorjdawson taylorjdawson changed the title Adds Tally wallet support 1.35.5-0.0.1: [feature] Adds Tally wallet support Dec 1, 2021
@taylorjdawson taylorjdawson merged commit 9e520a0 into blocknative:develop Dec 1, 2021
@greg-nagy greg-nagy deleted the feature/tally-wallet branch December 1, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onboard.js integration PR
2 participants