Support rendering trees nested deeper than 64 levels. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +97,7 @@ private fun StringBuilder.appendLinePrefix( | |||
| if (parentDepth > 0) { | |||
| append(' ') | |||
| } | |||
| val lastChild = lastChildMask and (1 shl parentDepth).toLong() != 0L | |||
| val lastChild = lastChildMask[parentDepth] | |||
There was a problem hiding this comment.
This is pretty nice though, on the other hand.
| val tree = generateSequence(Node("leaf")) { child -> | ||
| Node("node", Node("leaf"), child) | ||
| } | ||
| .take(34) | ||
| .take(300) |
There was a problem hiding this comment.
Ought to be enough for anybody…
60a21b0 to
ecab4e6
Compare
This is required for Compose support, which can have trees that go far beyond 64 levels deep.
ecab4e6 to
225411a
Compare
pyricau
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for Compose support, which can have trees that go far beyond
64 levels deep.