feat: confirmation dialog for deeplinks #783
Merged
+179
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lily-de
commented
Jan 26, 2025
•
alexhancock
approved these changes
Jan 26, 2025
| import 'react-toastify/dist/ReactToastify.css'; | ||
| import { ToastContainer } from 'react-toastify'; | ||
| import { ModelProvider } from './components/settings/models/ModelContext'; | ||
| import { ActiveKeysProvider } from './components/settings/api_keys/ActiveKeysContext'; | ||
|
|
||
| export default function App() { | ||
| const [fatalError, setFatalError] = useState<string | null>(null); | ||
| const [modalVisible, setModalVisible] = useState(false); |
There was a problem hiding this comment.
nit: can we use a more descriptive name of which modal? Something like confirmExtensionModalVisible
| }) { | ||
| return ( | ||
| <div className="fixed inset-0 bg-black/20 backdrop-blur-sm z-[9999]"> | ||
| <div className="fixed top-1/2 left-1/2 -translate-x-1/2 -translate-y-1/2 w-[400px] bg-white dark:bg-gray-800 rounded-xl shadow-xl border border-gray-200 dark:border-gray-700"> |
There was a problem hiding this comment.
Did we reference other modals when grabbing all the bg- border- etc classes for this?
We might compare backgrounds to the ones available from @nahiyankhan's big stying push now that we have nice things like bg-subtle
There was a problem hiding this comment.
i copied what you have in the extensions folder but will double check!
|
it is also possible to use electron.show from main.ts if it was less trouble (fair bit of work to weave in a modal from the renderer side) - just one option (but this gives more control of course) |
ba7808e to
bbb69b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.