Add user prompt for context length exceeded #1109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes block#1096 Add user prompt for further truncation or exit when context length exceeds limits. * Modify `crates/goose-cli/src/prompt.rs` to add `TruncateFurther` variant to `InputType` enum and `Input` struct, and add `ask_user_for_truncation` function to `Prompt` trait. * Modify `crates/goose/src/agents/extension.rs` to update `ContextLimit` error to include user prompt. * Add test cases in `crates/goose/tests/providers.rs` for user prompt on context length exceeded, including scenarios for further truncation and exit. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/block/goose/issues/1096?shareId=XXXX-XXXX-XXXX-XXXX).
michaelneale
reviewed
Feb 6, 2025
| @@ -30,10 +31,5 @@ pub enum InputType { | |||
| AskAgain, // Ask the user for input again. Control flow command. | |||
| Message, // User sent a message | |||
| Exit, // User wants to exit the session | |||
| } | |||
|
|
|||
| pub enum Theme { | |||
There was a problem hiding this comment.
was this meant to be removed?
|
looks like not well formed or automated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1096
Add user prompt for further truncation or exit when context length exceeds limits.
crates/goose-cli/src/prompt.rsto addTruncateFurthervariant toInputTypeenum andInputstruct, and addask_user_for_truncationfunction toPrompttrait.crates/goose/src/agents/extension.rsto updateContextLimiterror to include user prompt.crates/goose/tests/providers.rsfor user prompt on context length exceeded, including scenarios for further truncation and exit.For more details, open the Copilot Workspace session.